feat(config): apply top-level runtime settings - #12
Merged
Blankeos merged 3 commits intoAug 6, 2026
Conversation
Wire global tool config, custom instructions, and provider filters into the interactive App path so they match print-mode behavior.
Owner
|
Nice work on this. The parsing and print-mode wiring looked solid. Merge confidence: 4/5 My agent found a bug.. I reproduced the gap with:
// ~/.config/crabcode/crabcode.jsonc
{
"tools": { "bash": false },
"instructions": ["~/dotfiles/CUSTOM.md"]
}
The new commit fixes that. |
…very - add `ConfigRuntime`/`ConfigRuntimeOptions` to build tool permissions, discovery, and custom instructions from merged config in one place - switch interactive app and print mode to use shared runtime construction and remove duplicated setup logic - move print-mode interactive tool denies (`question`, `update_plan`) into shared runtime path - expose `Discovery::provider_is_enabled` for tests and extend runtime tests for shared wiring behavior
Owner
|
Merge confidence: 4.8/5 New change: Unify config → runtime assembly in LGTM from my side |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
cargo fmt --allcargo test config::configuration::tests::parses_and_applies_top_level_runtime_configuration